This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
[v8.x-cherrypick] http2,perf_hooks: perf state using AliasedBuffer #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-kaufman
approved these changes
Jan 25, 2018
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: nodejs/node#18300 Backport-PR-URL: nodejs#453 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mike Kaufman <[email protected]>
kfarnung
force-pushed
the
v8.x-perf_buffers
branch
from
ce15647
to
11035cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the patch from nodejs/node#18364 to our local v8.x branch. This resolves some TTD issues around modifying raw buffers that are exposed to script.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
perf_hooks