test: remove catch without argument binding and disable failing test …

…cases
nodejs · Jun 18, 2018 · 1f550c9 · 1f550c9
1 parent c88fd98
commit 1f550c9
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 2 deletions.
diff --git a/test/abort/abort.status b/test/abort/abort.status
@@ -22,3 +22,7 @@ prefix abort
 # This test is disabled for chakra engine because it depends
 # on v8-option --abort-on-uncaught-exception
 test-abort-uncaught-exception : SKIP
+
+# These tests require worker_threads which is not implemented
+# in node-chakracore
+test-addon-uv-handle-leak : SKIP
diff --git a/test/addons/uv-handle-leak/test.js b/test/addons/uv-handle-leak/test.js
@@ -16,7 +16,7 @@ try {
   const { isMainThread } = require('worker_threads');
   if (!isMainThread)
     common.skip('Cannot run test in environment with clean-exit policy');
-} catch {}
+} catch (e) {}
 
 binding.leakHandle();
 binding.leakHandle(0);

diff --git a/test/common/index.js b/test/common/index.js
@@ -84,7 +84,7 @@ exports.isGlibc = () => {
     const nmOut = spawnSync('nm', ['-D', libcInfo[0][1]]).stdout;
     if (/gnu_get_libc_version/.test(nmOut))
       return isGlibc = true;
-  } catch {}
+  } catch (e) {}
   return isGlibc = false;
 };
 

diff --git a/test/es-module/es-module.status b/test/es-module/es-module.status
@@ -36,3 +36,4 @@ test-esm-snapshot : SKIP
 test-esm-symlink : SKIP
 test-esm-symlink-main : SKIP
 test-esm-throw-undefined : SKIP
+test-esm-cjs-main : SKIP
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -214,6 +214,7 @@ test-async-hooks-destroy-on-gc : PASS,FLAKY
 test-error-serdes : SKIP
 
 # These tests are for worker_threads support, which is currently not implemented in Node-ChakraCore
+test-async-wrap-missing-method : SKIP
 test-message-channel : SKIP
 test-message-channel-sharedarraybuffer : SKIP
 test-message-port : SKIP