test: Correct invalid tsfn binding export #978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEady
requested review from
NickNaso,
gabrielschulhof,
legendecas,
mhdawson and
jschlight
legendecas
approved these changes
Apr 23, 2021
NickNaso
approved these changes
Apr 23, 2021
|
Implemented via #974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit c24c455#diff-994bd7eb26e23ba70f1d7faa2084e7c57f520e1ba8d8fb09a1cfa3610456d1a4 incorrectly updated the regular TSFN test with TypedTSFN.
The first attempt #974 still has crashes. I guess the action was re-ran and the previous CI failure is no longer visible.
This PR at least can go in while we troubleshoot the failing test. [NB: It may be the case that this fix could solve the intermittent issue itself, since the test implementation uses global static variables... but unlikely imo]