Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key for wapping drawing's system condition #970

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

kecsou
Copy link
Contributor

@kecsou kecsou commented Apr 13, 2021

No description provided.

@kecsou
Copy link
Contributor Author

kecsou commented Apr 13, 2021

I create this pull request for allowing developers to explicitly see how to add drawing's system conditions in the binding.gyp

@kecsou kecsou requested a review from legendecas April 15, 2021 09:19
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 8f120b0 into nodejs:main Apr 16, 2021
JckXia pushed a commit to JckXia/node-addon-api that referenced this pull request Apr 20, 2021
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Sep 23, 2021
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants