Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for C++11 compiler first #450

Closed
wants to merge 1 commit into from
Closed

Check for C++11 compiler first #450

wants to merge 1 commit into from

Conversation

agnat
Copy link
Collaborator

@agnat agnat commented Sep 12, 2015

As discussed in #448.

@rvagg
Copy link
Member

rvagg commented Sep 12, 2015

lgtm

@kkoopa
Copy link
Collaborator

kkoopa commented Sep 14, 2015

Something's wrong under AppVeyor. Does msvs2013 not set the proper define? It is C++11-capable, as it can compile the code, so something's wrong with the detection logic.

@kkoopa
Copy link
Collaborator

kkoopa commented Sep 14, 2015 •
edited
Loading

Yes, typical... Never get anything done right.
https://connect.microsoft.com/VisualStudio/feedback/details/763051/a-value-of-predefined-macro-cplusplus-is-still-199711l

Thanks for your feedback. Could you please provide some screenshots to help us better understand this scenario?

need to add #if defined(_MSC_VER) && _MSC_VER < 1800

@agnat
Copy link
Collaborator Author

agnat commented Sep 14, 2015

Really?!?...wow... just... wow. lol.

Just let me real quick...

@agnat
Copy link
Collaborator Author

agnat commented Sep 14, 2015

Like this?

@kkoopa
Copy link
Collaborator

kkoopa commented Sep 14, 2015

The jury is still out, but I guess the outcome will be pleasing.

@kkoopa
Copy link
Collaborator

kkoopa commented Sep 14, 2015

Seems to work.

@kkoopa kkoopa added this to the 2.1 milestone Sep 14, 2015
@agnat agnat force-pushed the feature/check_c++_stdandard_version branch from d84d1ac to c295a6e Compare September 15, 2015 18:29
@brodycj brodycj mentioned this pull request Sep 30, 2015
Closed
@brodycj
Copy link

brodycj commented Sep 30, 2015

We should also add:

#define NODE_4_00_MODULE_VERSION 46

see #477

@kkoopa
Copy link
Collaborator

kkoopa commented Oct 5, 2015

Yes, that should be added, although it ought to be NODE_4_0_MODULE_VERSION.

@kkoopa
Copy link
Collaborator

kkoopa commented Oct 7, 2015

Merged as 48cc1d8

@kkoopa kkoopa closed this Oct 7, 2015
@kkoopa kkoopa deleted the feature/check_c++_stdandard_version branch October 28, 2015 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@agnat @rvagg @kkoopa @brodycj