You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the method relative('.', __dirname) in include_dirs.js the path isn't got properly when the parent path is in a shared resource (a link to a network resource in the case of windows):
To reproduce this behavior, run the include_dirs.js with node 6 inside of a shared folder of virtualbox, or in a network resource linked to a drive letter.
The text was updated successfully, but these errors were encountered:
The latest implementation of the path.relative function of node v6 seems
to be broken when either of the "from" or "to" paths are in a network
resource of windows, removing the leading backslashes "\\" and returning
a wrong path [0].
The new approach employs the path.resolve function that returns the
absolute path to the nan headers and seems to work fine in the case of
node v6 running in a windows box.
Tests:
* Windows 10 with node 4.3.0:
c:\>node -e "console.log(require('path').relative('.','\\\\VBOXSRV\\vagrant'))"
returns: \\VBOXSRV\vagrant\
* Windows 10 with node 6.5.0:
c:\>node -e "console.log(require('path').relative('.','\\\\VBOXSRV\\vagrant'))"
returns: VBOXSRV\vagrant\
[0] nodejs#600
With the method
relative('.', __dirname)
in include_dirs.js the path isn't got properly when the parent path is in a shared resource (a link to a network resource in the case of windows):vboxsrv\vagrant\NODE_MODULES\nan
(which doesn't exists)To reproduce this behavior, run the include_dirs.js with node 6 inside of a shared folder of virtualbox, or in a network resource linked to a drive letter.
The text was updated successfully, but these errors were encountered: