-
Notifications
You must be signed in to change notification settings - Fork 501
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use GetBackingStore() instead of GetContents() (#888)
* use GetBackingStore() instead of GetContents() Use GetBackingStore() instead of GetContents() for v8 >= 8.0 as GetContents() has been deprecated. Node.js 14 will use 8.1 It would be possible to use GetBackingStore() already with 7.9 but this would lead to issues with Node.js 13 as it uses 7.8 till 13.2.0. Additionally update testmatrix to use latest electron versions and add electron 8. Co-authored-by: Ben Noordhuis <[email protected]>
- Loading branch information
1 parent
2c4ee8a
commit 2c023bd
Showing
2 changed files
with
11 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c023bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to fix this problem? Please help
error LNK2001: unresolved external symbol "__declspec(dllimport) public: class std::shared_ptr<class v8::BackingStore> __cdecl v8::ArrayBuffer::GetBackingStore(void)"
Note: - Electron 13.0.0
2c023bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same problem, and I found that in Electron 12.0.9 you can use
GetContents
methods instead.2c023bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xing1P or @Jiahui-Yan did you ever come up with a solution / workaround for Electron 13+?
2c023bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2c023bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jiahui-Yan thank you for the reply. I have been trying to figure out how to convert node-canvas from NaN to n-api via node-addon-api but have had no luck. Do you have any advice? Any good resources / tutorials? Thanks!