This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
doc: move code of conduct to CODE_OF_CONDUCT.md #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently in the GOVERNAMCE.md file. I think it should be easy to find and not buried in a document people may not see.
typo in name: it should be CODE_OF_CONDUCT, not CODE_OF_CONDCUCT.
…On Thu, Feb 15, 2018 at 10:17 AM Benjamin Gruenbaum < ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#29 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYnRAK-oIKGbKdvdAP0glegNW2S2z2Wks5tU-gLgaJpZM4SGYUP>
.
|
@targos good catch, I've pushed a new commit that should fix both points you raised |
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently in the GOVERNAMCE.md file. It doesn't seem like a good
idea to assume people are going to look for it there.