Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-12-05 Meeting Notes #177

Merged
merged 5 commits into from
Dec 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions doc/meetings/2023-12-05.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Node.js Loaders Team Meeting 2023-12-05

## Links

* **Recording**: https://www.youtube.com/watch?v=aEf3uzOFopY
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/176

## Present

* Geoffrey Booth: @GeoffreyBooth
* Bryan English: @bengl
* Ayan Khan: @khanayan123
* Jacob Smith: @jakobjingleheimer

## Agenda

- https://github.com/nodejs/node/issues/47888
- https://github.com/nodejs/node/issues/50948

## Announcements

* Extracted from **loaders-agenda** labeled issues and pull requests from the **nodejs org** prior to the meeting.

### - https://github.com/nodejs/node/issues/47888

The “patch the source” approach is in progress and seems promising, and could be
better overall than a “mutate the exports” solution. The patch approach will
need to be used for old versions of Node.js anyway so it might not make much
sense to add a new API to enable a mutation alternative, especially if the patch
approach can be made more performant (such as by having patched files already
available on disk, rather than patching on the fly). Bryan and Ayan will
investigate. If a new API is desired, it probably won’t involve any breaking
changes to existing APIs and therefore the hooks API should be okay to go stable
soon.

### - https://github.com/nodejs/node/issues/50948

The deadlock might be avoidable if we change the first argument of `register`
from being any specifier to instead only be a relative or absolute URL. So
anyone doing `register(‘foo’)` today would need to change that to
`register(import.meta.resolve(‘foo’))`, but we think this might fix the deadlock.