Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use codecov instead of coveralls #371

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

mmarchini
Copy link
Contributor

coveralls is failing, and codecov seems to be working on actions now, so
replace coveralls with codecov.

coveralls is failing, and codecov seems to be working on actions now, so
replace coveralls with codecov.
@codecov-commenter
Copy link

Codecov Report

Merging #371 into master will increase coverage by 0.05%.
The diff coverage is 81.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   78.93%   78.98%   +0.05%     
==========================================
  Files          33       33              
  Lines        4262     4744     +482     
==========================================
+ Hits         3364     3747     +383     
- Misses        898      997      +99     
Impacted Files Coverage Δ
src/constants.h 88.88% <ø> (+11.11%) ⬆️
src/error.cc 82.60% <0.00%> (-1.61%) ⬇️
src/error.h 100.00% <ø> (+12.50%) ⬆️
src/llv8.cc 71.71% <56.75%> (-1.35%) ⬇️
src/printer.cc 81.15% <68.33%> (+3.45%) ⬆️
src/llv8-inl.h 90.42% <84.37%> (-2.50%) ⬇️
test/plugin/frame-test.js 83.33% <84.61%> (-4.17%) ⬇️
src/llv8-constants.cc 85.92% <91.66%> (+2.91%) ⬆️
src/constants.cc 82.08% <100.00%> (+7.84%) ⬆️
src/llscan.cc 59.41% <100.00%> (-1.85%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9a668...f9b77f0. Read the comment docs.

@mmarchini
Copy link
Contributor Author

mmarchini commented Aug 5, 2020

@nodejs/llnode @nodejs/diagnostics this unbreaks linux CI on pull requests (OS X has a different problem due to Catalina and we should disable OS XCI for now until someone can investigate how to fix it)

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mmarchini mmarchini merged commit aace784 into nodejs:master Aug 6, 2020
@mmarchini mmarchini deleted the codecov-actions branch August 6, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants