Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: remove unwanted require #359

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Apr 9, 2020

No description provided.

@mmarchini
Copy link
Contributor

Before every action started failing for no apparent reason, we had two failures on OS X which I think are not related to this PR (might be related to yesterday's Node.js releases): https://github.com/nodejs/llnode/actions/runs/74853245

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files          33       33           
  Lines        4744     4744           
=======================================
  Hits         3747     3747           
  Misses        997      997           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aad67d...51947cc. Read the comment docs.

@mmarchini mmarchini merged commit 4b868f7 into nodejs:master Aug 12, 2020
@rickyes rickyes deleted the remove-require branch August 12, 2020 01:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build a8954c8792e105c11dc0fcb91a9ab0ad8a7eface-PR-359

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.8%) to 78.936%

Totals Coverage Status
Change from base Build fdddce0d2c7d15993584ec828569b94d61ac374a: 4.8%
Covered Lines: 3729
Relevant Lines: 4711

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants