Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix source list on V8 7.4 #316

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

No description provided.

@mmarchini mmarchini added priority author ready PRs that have at least one approvals, no pending requests for changes, and a CI started. labels Oct 7, 2019
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #316 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #316      +/-   ##
=========================================
- Coverage   78.68%   78.4%   -0.28%     
=========================================
  Files          33      33              
  Lines        4246    4247       +1     
=========================================
- Hits         3341    3330      -11     
- Misses        905     917      +12
Impacted Files Coverage Δ
src/llv8.h 80.95% <ø> (-2.39%) ⬇️
src/llnode.cc 74.1% <100%> (-0.31%) ⬇️
src/llv8.cc 70.53% <100%> (-0.28%) ⬇️
src/llv8-constants.h 98.48% <0%> (-1.52%) ⬇️
src/llv8-constants.cc 82.1% <0%> (-0.96%) ⬇️
src/llv8-inl.h 91.87% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79a008...baa2fa7. Read the comment docs.

mmarchini added a commit that referenced this pull request Oct 8, 2019
PR-URL: #316
Reviewed-By: Colin Ihrig <[email protected]>
@mmarchini
Copy link
Contributor Author

Landed in ec01604

@mmarchini mmarchini closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approvals, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants