build: merge gyp_llnode into scripts/configure.js #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch drops the support for the original gyp. Building the
plugin now requires node-gyp which detects the necessary
configurations that we need from gyp_llnode. The original
gyp build flow has been broken without being noticed so it
should be safe to remove support for that.
- Renames the gyp and gypi files so they are easier to recognize
- llnode.gyp -> binding.gyp
- common.gypi -> llnode.gypi
- options.gypi -> config.gypi
- Renames the gyp variables
- lldb_dir to lldb_header_dir because that's the directory used
to search for headers.
- lldb_build_dir to lldb_lib_dir because that's the directory
used to search for library files.
- Added documentation on how to configure these variables from
the command line.
- Clarify that the lldb_exe npm config is only used to retrieve
lldb versions.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drops the support for the original gyp. Building the
plugin now requires node-gyp which detects the necessary
configurations that we need from gyp_llnode. The original
gyp build flow has been broken without being noticed so it
should be safe to remove support for that.
to search for headers.
used to search for library files.
the command line.
lldb versions.
Refs: #181