-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: don't crash with no arguments to print #106
Conversation
This commit prevents the DoExecute() methods from segfaulting when the cmd argument is null.
Replaced the remaining uses of |
This commit allows stderr to be scripted in the same way that stdout is.
OK, I allowed stderr to be scripted the same way that stdout currently is. Then, I added a test for the usage messages. Those commands segfault on master, and work correctly with the fixes in this PR. |
@bnoordhuis what is the policy for PRs getting landed in this repo? I technically have commit rights and can land this myself, but I don't want to step on any toes either. |
Go ahead and land it, no toes to worry about. |
@bnoordhuis @cjihrig - I can land things but I'm not sure whether I should be able to in a Node.js repo or whether my access ended up being grandfathered in when @indutny moved the repo from his space to the nodejs org. So I don't usually unless the PR has had a couple of LGTMs and been waiting a little while! |
@hhellyer Go for it! :-) |
This commit prevents a segfault on
v8 print
.I'll be adding a test as well, but it requires some changes to
test/common.js
first.