src: implement v8 inspect --array-length for large arrays
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
joyeecheung
force-pushed
the
array-view
branch
2 times, most recently
from
6dd153f
to
1d46498
Compare
|
@bnoordhuis @indutny Thanks for the review, updated per #105 (review) PTAL. I have tested this with v4.8.3, v6.10.0 and v8.0.0 on MacOS 10.12.4, all tests have passed. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@bnoordhuis Fixed the indentation, PTAL. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests for
--string-lengthsince they are pretty similar...Refs: #89
cc:/ @bnoordhuis