Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install on Windows. #321

Open
danny-su opened this issue Oct 24, 2019 · 5 comments
Open

Cannot install on Windows. #321

danny-su opened this issue Oct 24, 2019 · 5 comments

Comments

@danny-su
Copy link

if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" build /p:CLToolExe="clang-cl.exe" /p:CLToolPath="C:\Program Files\LLVM\bin" ) else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" build /p:CLToolExe="clang-cl.exe" /p:CLToolPath="C:\Program Files\LLVM\bin" )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Users\danny\AppData\Roaming\npm\node_modules\llnode\build\binding.sln : error MSB4014: The build stopped unexpectedly because of an internal failure. C:\Users\danny\AppData\Roaming\npm\node_modules\llnode\build\binding.sln : error MSB4014: System.ArgumentException: The name "plugin:CLToolExe=clang-cl. exe" contains an invalid character ".".

@bzoz
Copy link

bzoz commented Apr 2, 2020

Please provide the entire, verbose log (add --verbose to the npm command). Put it inside triple ticks so the formatting works:

```
like this, output goes here
```

Also: what's your Windows version and Visual Studio version?

@No9
Copy link
Member

No9 commented Apr 5, 2020

I also suspect that the error is accurate

error MSB4014: System.ArgumentException: The name "plugin:CLToolExe=clang-cl. exe" contains an invalid character ".".

Please can you post the file C:\Users\danny\AppData\Roaming\npm\node_modules\llnode\build\binding.sln

@manuel220x
Copy link

manuel220x commented Sep 29, 2020

having the same issue (LLVM 9)

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 2015
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "plugin", "plugin.vcxproj", "{7B017421-278E-EC0A-5B2D-BDDD478EE171}"
EndProject
Global
	GlobalSection(SolutionConfigurationPlatforms) = preSolution
		Debug|x64 = Debug|x64
		Release|x64 = Release|x64
	EndGlobalSection
	GlobalSection(ProjectConfigurationPlatforms) = postSolution
		{7B017421-278E-EC0A-5B2D-BDDD478EE171}.Debug|x64.ActiveCfg = Debug|x64
		{7B017421-278E-EC0A-5B2D-BDDD478EE171}.Debug|x64.Build.0 = Debug|x64
		{7B017421-278E-EC0A-5B2D-BDDD478EE171}.Release|x64.ActiveCfg = Release|x64
		{7B017421-278E-EC0A-5B2D-BDDD478EE171}.Release|x64.Build.0 = Release|x64
	EndGlobalSection
	GlobalSection(SolutionProperties) = preSolution
		HideSolutionNode = FALSE
	EndGlobalSection
EndGlobal

@SuibianP
Copy link

SuibianP commented Sep 19, 2024

nodejs/node-gyp@53d8cb9 (nodejs/node-gyp#1164) should be the cause.

SuibianP added a commit to SuibianP/llnode that referenced this issue Sep 25, 2024
nodejs/node-gyp#1164 interprets additional node-gyp build parameters as
target names, which breaks the current way CL configs are passed to
msbuild in install.js.

Move the detection logic into configuration phase and pass CL configs as
gyp variables.

Fixes nodejs#321, fixes nodejs#377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants