Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Small style fixes to have the same visual result on IE8 and IE9 [ie-support] #89

Closed
wants to merge 1 commit into from
Closed

Conversation

AntouanK
Copy link
Contributor

  • remove and which are not supported in IE8
  • remove flex and use float instead
  • remove border on the logo link
  • fix footer and header links
  • use hex color instead of rgba ( yes, not supported on IE8 )

Comparisons:
IE8 before
screen shot 2015-01-19 at 22 18 12

IE8 after
screen shot 2015-01-19 at 22 18 19

IE9 before
screen shot 2015-01-19 at 22 18 48

IE9 after
screen shot 2015-01-19 at 22 18 55

- remove <nav> and <header> which are not supported in IE8
- remove flex and use float instead
- remove border on the logo link
- fix footer and header links
- use hex color instead of rgba ( yes, not supported on IE8 )
@snostorm
Copy link
Contributor

Thanks for taking time to put together the PR @AntouanK :)

Honestly, not too concerned with IE8 myself. We (I?) have bigger ambitions for the site design and doubt IE8 -- or even IE9 -- will regularly be reviewed for quality.

That said, as soon as we implement a build process as per #22 we should be using auto-prefixer to catch things like the missing "ms" prefix for flexbox.

But, that's just my €0.02. I'll wait to let the rest of the WG chime in.

@therebelrobot
Copy link
Contributor

Arrrg. We totally should have talked about scope in the meeting today. Which browsers will we support, which devices, etc. I never start a freelance project without defining all that... hangs head in shame

A short list we would need to decide coverage for would include

  • Browsers
    • IE (6,7,8,9,10,11)
    • Spartan (when available)
    • Firefox (and how many versions back)
    • Opera (and how many versions back)
    • Chrome (I think this is a given, but also how many versions back)
  • Platforms
    • iOS - (browsers, versions and which devices)
    • Android - (browsers, versions and which devices)
    • Windows
    • Mac
    • Linux

@AntouanK
Copy link
Contributor Author

I get that supporting older IE it is not a priority. But it was a simple fix to make it look "decent" and not broken, so I made a PR.

@therebelrobot therebelrobot mentioned this pull request Jan 19, 2015
10 tasks
@therebelrobot
Copy link
Contributor

This PR in specific looks good, I say we merge it for now, but we do need to address long term what our scope with this site will be.

👍 for merge

@snostorm
Copy link
Contributor

@AntouanK yup, I get it. I know overall the fix is a nice short term win (which - again - thanks for doing this PR), but I'm just concerned with how long the effort will last if merged.

Maintaining IEX support is going to have a cost to it over time. A cost that will grow as the complexity of the site increases.

@therebelrobot
Copy link
Contributor

@snostorm, I opened an issue for coverage, let's move this discussion over there for now. If we decide later we won't support earlier versions, it doesn't hurt to revert the commits.

@snostorm
Copy link
Contributor

I'm a 👎 on this as-is @therebelrobot. Again, it seems innocent, but removes cleaner (semantic) markup, our ability to have modern (alpha-based) CSS, etc.

Edit: I wrote "as-is" to indicate that some alternative changes might be able to be made to find a middle ground.

@therebelrobot
Copy link
Contributor

Fair enough. I'll 👎 this merge then until we define scope better. @AntouanK , thank you so much for the contrib, but I think we need to define a few more items with scope before we start merging PRs like this. I'm going to close this for the time being. I'll loop you back into this discussion if we decide to support IE8.

@Fishrock123
Copy link
Contributor

-1 to IE8 support. I'm not mucking around with that stuff now or ever.

@therebelrobot
Copy link
Contributor

@Fishrock123 , @snostorm , let's move this discussion to #91 for more coverage info

<a href="https://webchat.freenode.net/?channels=io.js">IRC Chat</a>
<a href="http://logs.libuv.org/io.js/latest">Logs</a>
<a href="https://github.com/iojs/io.js/blob/v1.x/GOVERNANCE.md#readme">Governance</a>
</div>

This comment was marked as off-topic.

This comment was marked as off-topic.

@mikeal
Copy link
Contributor

mikeal commented Jan 19, 2015

We will eventually want to support IE8 but I'm fine with punting on that support until we do the new build process, which I'm sure will effect stuff like this.

@AntouanK
Copy link
Contributor Author

I personally hate supporting older IE crappy browsers but it's a fact that some people, especially on some countries, still use them.
So I think they should be able to at least see a "decent" version of a website.

What other plans do you have for this website? I thought it's only a simple page with links to download io.js, FAQ, readme etc. Nothing complex...

Anyway, I would definitely like to contribute if I can.

Thanks.

@therebelrobot
Copy link
Contributor

We appreciate the support @AntouanK :) As we further finalize our build system this week, we'll have a better idea of how to handle volunteer support. Take a look through the issues currently open and with the tag [discuss], we have a couple different directions we may end up taking the site.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants