-
Notifications
You must be signed in to change notification settings - Fork 130
Moves in-site nav links to header, adds docs link #31
Conversation
cc @zeke Thinking of this with the same sizing/color as the text logo, LGTY? I'll fix it up. |
👍 |
I'd like to move back to the messaging I put together yesterday. This is a little long winded :) For reference, this was the messaging:
|
Oh, Whoops. Didn't realize that was removed. |
If the structural changes are good we can handle any tweaks (especially to content wording, as per @mikeal) back on the primary 1.0.0 branch? |
Maybe we should move the government and nightly lines into the footer, or below the release? |
It would be best to note the nightly link in a similar style as the beta release and, hopefully soon, we can actually swap that out for an automated link to the latest nightly. |
I'm sure soon enough there will be some sort of download/releases page. |
Governance should be another link next to the GitHub Issues and whatnot. It was top level messaging before we had a release, and still is an important part of the project, but IMO the top level messaging should just be about what is the in current release and what users can sink their teeth in to. |
Yeah. I'm mulling over build options right now, though I'm still just leaning towards a .js that builds markdown and shoves it into a handlebars template. |
it's in the FAQ iirc. |
any objections to merging this? i'd like to tweak the messaging back in the 1.0.0 branch. |
I'm going to tweak this and land it. Feel free to patch the other branch with other things. |
Why don't I log an issue about the logo selection and nightly process in io.js so that we can statically link to a "latest logo" and "latest nightly" build of each type rather doing a whole build and push process? |
The idea is to have a script which the build triggers, not us. (and out of repo) |
+1 latest nightly (being a static and predictable link.) Same for nightly docs, etc. Logo I have mixed feelings on, since (if) we have 1-logo-per-release down the line, we might end up having the CHANGELOG/release articles/etc. show the logo that existed for the version. Would be a nice touch for historic purposes, eventually. |
I reverted the messaging the main branch. |
@mikeal @Fishrock123 Fixed this branch to deal with the conflict that commit added. It is merge-able once again. (We should probably merge sooner than later and just tweak anything else on the main 1.0.0 PR, as it isn't live anyway.) |
Please don't merge upstream. Rebase, if anything. |
I understand the need to be picky about cleanliness off the commit log on bigger projects but this is just a simple website, I don't think that we need to be obsessing about merge vs. rebase issues. |
@Fishrock123 @mikeal I squashed this back to a single commit. I'll stay out of the rebase-or-not debate for tonight ;) Should be good to merge to the mainline 1.0.0 branch. |
No description provided.