Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Release v1.4.3 #252

Closed
wants to merge 4 commits into from
Closed

Release v1.4.3 #252

wants to merge 4 commits into from

Conversation

snostorm
Copy link
Contributor

@snostorm snostorm commented Mar 1, 2015

Latest version is v1.4.2 but v1.4.3 is coming fast as per nodejs/node#995

Blocked as per nodejs/node#1017 -- do not merge for now.

@Fishrock123
Copy link
Contributor

@snostorm could you remove the rebuild from this? It'l be outdated when we merge it.

@snostorm
Copy link
Contributor Author

snostorm commented Mar 2, 2015

@Fishrock123 if there end up being any merge conflicts on public before it goes live, we'll patch with another rebuild on the PR. So far, almost 48 hours later, this one is still good to merge.

@Fishrock123
Copy link
Contributor

Landed in 416cd0d...2e6d88e after skipping 2? commits.

@iojs/website can we please start avoiding rebuilds in PR's?

@snostorm
Copy link
Contributor Author

snostorm commented Mar 3, 2015

I have mixed feeling about the rebuilds in PRs. I actually wish all content updates had their own updates to public files included for easier merging. It makes sense to me that the .md change should include the related .html change.

@snostorm snostorm deleted the release-v1.4.3 branch March 13, 2015 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants