Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msvs): correctly rename object files for absolute paths #71

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

targos
Copy link
Member

@targos targos commented Oct 14, 2020

No description provided.

Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rvagg
Copy link
Member

rvagg commented Oct 14, 2020

weird fix, but ok, if this fixes it let's get this merged and pushed out in node-gyp

pylib/gyp/generator/msvs.py Outdated Show resolved Hide resolved
Co-authored-by: Christian Clauss <[email protected]>
@targos targos merged commit f2c7618 into nodejs:master Oct 14, 2020
@targos targos deleted the fix-abs-sourcepath branch October 14, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants