Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to test Node.js POSIX integration #38

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

targos
Copy link
Member

@targos targos commented May 3, 2020

Build on ubuntu-latest and macOS-latest.

Build on ubuntu-latest and macOS-latest.
@gengjiawen

This comment has been minimized.

@ryzokuken ryzokuken merged commit 58eea54 into nodejs:master Dec 28, 2020
@targos
Copy link
Member Author

targos commented Dec 28, 2020

@ryzokuken this PR was not ready :(

@ryzokuken
Copy link
Contributor

I'm sorry! I couldn't guess that from the changes or the conversation here and the PR was not set to "draft" mode 😅

Would you prefer to make a quick follow-up or should I revert it?

@targos
Copy link
Member Author

targos commented Dec 28, 2020

We should revert it. The CI was not passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants