Merged
Conversation
Member
|
The wasm test is failing on the main branch as well: https://github.com/nodejs/gyp-next/actions/runs/13924144412 |
Member
|
@toyobayashi would you mind helping us identifying the issue? Thank you! |
Contributor
|
It seems that the latest version Visual Studio LLVM clang doesn't support After I switch |
Contributor
Author
|
Can I please get approval on the Python-related changes in this pull request? We can move the Windows wasm discussion to |
legendecas
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/astral-sh/ruff/releases
https://docs.astral.sh/ruff
Unrelated failure: