-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: resolve issue with relative paths during linking #284
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Searching through usages on library_dirs
: https://github.com/search?type=code&q=library_dirs+path%253A*.gyp. It seems to me there are relative paths in library_dirs
in the wild that will be break by this change. I think this PR should be released as a breaking change.
Would you mind updating the list in the document https://github.com/nodejs/gyp-next/blob/main/docs/InputFormatReference.md#pathname-relativization as well?
Thank you! |
Seems like we don't have tests on this, but it will be great if you can update these generators as well to keep them in align. |
hi~@legendecas; I'm not very familiar with the project and don't know how to test with cmake/nanja/msvc. Could you please advise on how to make modifications? |
nodejs/node-gyp#3128