Fix compile_commands.json output location when generator_output is None #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Apr 2, 2024
cclauss
reviewed
Apr 2, 2024
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
StefanStojanovic
approved these changes
Apr 2, 2024
Contributor
StefanStojanovic
left a comment
StefanStojanovic
left a comment
There was a problem hiding this comment.
@segevfiner I've checked this code together with nodejs/node#52279 in the node repo, and the build passed. The files were created in out\{Debug|Release} as expected.
cclauss
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #238 after discussion at nodejs/node#52279 (comment)
cc @anonrig @cclauss