feat: generate compile_commands.json with ninja #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
ninja-compiledb
branch
from
9d05a64
to
c78f680
Compare
legendecas
force-pushed
the
ninja-compiledb
branch
from
c78f680
to
a57a970
Compare
cclauss
requested changes
Mar 8, 2024
|
@cclauss would you mind taking a look again? thank you! |
|
@cclauss kindly ping, would you mind taking another look at this? Thanks! |
cclauss
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ninja supports generating
compile_commands.jsonfrom ninja files. The generatedcompile_commands.jsonresolves the generated product path as well, which is not supported in thegyp.generator.compile_commands_json.To generate
compile_commands.jsonwith ninja, define generator flag-Gcompile_commandswhen running gyp.