Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 0.17.0 #234

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 12, 2024

🤖 I have created a release beep boop

0.17.0 (2024-04-29)

Features

  • generate compile_commands.json with ninja (#228) (7b20b46)

Bug Fixes

  • failed to detect flavor if compiler path include white spaces (#240) (f3b9753)
  • support cross compiling for wasm with make generator (#222) (de0e1c9)
  • support empty dictionary keys in input (#245) (178459f)
  • update Ruff to 0.3.1 (876ccaf)

This PR was generated with Release Please. See documentation.

@cclauss
Copy link
Contributor

cclauss commented Mar 12, 2024

@github-actions github-actions bot force-pushed the release-please--branches--main--components--gyp-next branch from 9d32ebe to f7ae00e Compare March 30, 2024 21:03
@github-actions github-actions bot changed the title chore(main): release 0.16.3 chore(main): release 0.17.0 Apr 1, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--gyp-next branch 2 times, most recently from 76e1118 to d50d5f5 Compare April 2, 2024 07:44
@cclauss
Copy link
Contributor

cclauss commented Apr 11, 2024

Let's make a new release to https://pypi.org/project/gyp-next because on Python 3.12 running pipx run gyp-next --help as recommended in https://github.com/nodejs/gyp-next/blob/main/README.md causes:

NOTE: running app 'gyp' from 'gyp-next'
Traceback (most recent call last):
  File "/Users/cclauss/.local/pipx/.cache/3a4d954fd3b5f0e/bin/gyp", line 5, in <module>
    from gyp import script_main
  File "/Users/cclauss/.local/pipx/.cache/3a4d954fd3b5f0e/lib/python3.12/site-packages/gyp/__init__.py", line 9, in <module>
    import gyp.input
  File "/Users/cclauss/.local/pipx/.cache/3a4d954fd3b5f0e/lib/python3.12/site-packages/gyp/input.py", line 19, in <module>
    from distutils.version import StrictVersion
ModuleNotFoundError: No module named 'distutils'

@legendecas
Copy link
Member

legendecas commented Apr 19, 2024

Was the pip package published manually? It seems @ryzokuken is the owner of the package.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--gyp-next branch from d50d5f5 to 812f0f0 Compare April 22, 2024 22:50
@cclauss cclauss mentioned this pull request Apr 23, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--gyp-next branch 2 times, most recently from 418dbbf to 36e20ac Compare April 23, 2024 10:10
@ryzokuken
Copy link
Contributor

@legendecas yes, I do remember manually pushing the package to PyPI at the time. I would really like to transfer ownership to the Node.js project at this point since I originally maintained gyp only to keep things going in the absence of a maintainer.

@targos
Copy link
Member

targos commented Apr 25, 2024

How does package ownership work on PyPi?

@legendecas
Copy link
Member

Maybe we should setup an org account for the project?

@ryzokuken
Copy link
Contributor

I'm going to add @legendecas as maintainer just so there's no hard dependency on me and an action may be taken even when I'm unavailable... That said, as I was just discussing with @legendecas privately, the ideal situation would be to have a Node.js pypi account with properly managed credentials and setup GitHub actions to publish on release.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--gyp-next branch from 36e20ac to 950630d Compare April 29, 2024 09:36
@github-actions github-actions bot force-pushed the release-please--branches--main--components--gyp-next branch from 950630d to e2ad6b1 Compare April 29, 2024 09:38
@cclauss
Copy link
Contributor

cclauss commented Apr 29, 2024

Can we please get a release to PyPI?

@legendecas
Copy link
Member

legendecas commented Apr 30, 2024

I'll publish new version today and setup publish automation as well.

@legendecas legendecas merged commit 8c1a9e0 into main Apr 30, 2024
@legendecas legendecas deleted the release-please--branches--main--components--gyp-next branch April 30, 2024 12:31
Copy link
Contributor Author

@cclauss
Copy link
Contributor

cclauss commented Apr 30, 2024

% pipx run gyp-next --help and pipx run gyp-next --version on Python >= 3.12 both fail with:
ModuleNotFoundError: No module named 'distutils'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants