fixup! build(deps): bump @octokit/rest from 20.1.1 to 21.0.1 #541
Conversation
|
Do tests pass for you locally? They're failing in CI.... |
|
OK, after a small linter fix, the tests pass with Node.js 22 but not Node.js 20. Node.js 20 is what we run in production, so we'll want to fix that. |
|
Seems to be a race condition, so I must have forgotten to await sth. Taking a look rn |
|
it seems we were missing a couple returns in the original code and tap wasn't waiting for promise resolution. It should be fixed now |
|
Tests pass now. 👍 There is now a potentially-competing PR at #542. If there's benefit to landing this one first as an incremental step, I'm good with that. If not, then I'm really sorry that you put in the work and now this might not land. It happens, but it still sucks, and I'm sorry. |
|
Closing in favor of #542. Thank you for the effort, though! |
Require of octokit migrated to
await importto accommodate chango to ESM-only