scripts: fix reading credentials for jenkins #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code assumes that the credentials are already in base64, but they are actually not. The code has to read the credentials in plain text and base 64 encode them.
|
#206 (comment) 😬 😬 |
|
Ohmy, not sure why I didn't see that suggested change while reviewing & landing last week. Since this was originally suggested by @maclover7 and @thefourtheye opened this PR, I assume agree this should be headed to production :) |
phillipj
approved these changes
Jan 15, 2019
|
@maclover7 Sorry, I couldn't address your comment on time. That is why I had to open a new PR with your suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code assumes that the credentials are already in base64,
but they are actually not. The code has to read the credentials in plain
text and base 64 encode them.
Ref: #206 (comment)
@maclover7 @phillipj