Wrong inline ARM Jenkins status on node PRs

[phillipj]

There seems to be something fishy with the inline PR statuses forwarded from Jenkins. Looking at a few PRs which seem to have the same issue, it may be isolated to ARM builds.

These three PRs has inline ARM failure but Jenkins says they're green:

• doc: add Google Analytics tracking. node#6601: https://ci.nodejs.org/job/node-test-commit-arm/6587/
• deps: upgrade npm to 4.0.5 node#10330: https://ci.nodejs.org/job/node-test-commit-arm/6613/
• deps: cherry-pick 081fce3 from V8 upstream node#10342: https://ci.nodejs.org/job/node-test-commit-arm/6622/

@jbergstroem you see anything suspicious with how the ARM builds are configured by any chance?

[phillipj]

Seeing this in the logs related to PR 10342 and ARM:

19:05:25.868Z  INFO bot: Jenkins / Github PR status updated (req_id=d37fa1da-7246-4b88-bb8e-759d9d14be56, pr=10342, job=test/arm-fanned, status=pending)
19:05:38.608Z  INFO bot: Jenkins / Github PR status updated (req_id=f5b4cc52-097c-4026-a6aa-406bf0531197, pr=10342, job=test/arm, status=pending)
19:05:49.808Z  INFO bot: Jenkins / Github PR status updated (req_id=fbd97ff0-81a9-4d6e-91d4-a9519a490b66, pr=10342, job=test/arm, status=pending)
19:05:55.256Z  INFO bot: Jenkins / Github PR status updated (req_id=ab6678d5-2c40-4743-a1da-6cacb646f8a4, pr=10342, job=test/arm, status=pending)
19:30:23.187Z  INFO bot: Jenkins / Github PR status updated (req_id=5bd9d410-b387-422f-87ec-650a37982605, pr=10342, job=test/arm-fanned, status=success)
19:43:45.646Z  INFO bot: Jenkins / Github PR status updated (req_id=d97e6bfd-d6f8-44ad-bdca-981fa8f545aa, pr=10342, job=test/arm, status=success)
19:43:45.790Z  INFO bot: Jenkins / Github PR status updated (req_id=efead0d0-1155-4327-83fe-db966500ac3b, pr=10342, job=test/arm, status=failure)

From the looks of that, it's Jenkins pushing a failure status.

[jbergstroem]

I've done some changes to both arm-fanned and arm. I think it might be related to the matrix type of job holds thumbs.

[phillipj]

@jbergstroem to clearify, you did some changes supposed to fix these issues? Or had you done some changes previously which might have caused this issues in the first place?

Still seeing this in new PRs: nodejs/node#10524 which says https://ci.nodejs.org/job/node-test-commit-arm/6788/ failed when it didn't.

[gibfahn]

(I think) related: nodejs/build#572

[jbergstroem]

The changes I did definitely didn't make things worse, but the issue still persists :(

[phillipj]

Any updates here? Kinda sad to see this happening for most PRs, I assume it adds some doubts about whether or not these statuses are correct at all..

[jbergstroem]

I've looked several times. Can't find whats wrong. Happy to share access but I think you already have it?

[phillipj]

@jbergstroem I'd expect a "Configure"-link or something similar in the menu to the left if I had access?

[gibfahn]

It's only people in @nodejs/jenkins-admins who can see it right?

[Trott]

Is anyone actively working on this? Seems to have become one of those perma-ignore things for a lot of people in the main repo, which isn't healthy... :-( Not even sure who to loop in... @nodejs/build maybe? @Fishrock123 maybe?

[gibfahn]

cc/ @nodejs/jenkins-admins

[phillipj]

Have to admint I haven't remembered to look into this I'm afraid. But by looking at the latest PRs and their inline status, it might look like failing ARM builds aren't as frequent anymore. @Trott would you agree?

[gibfahn]

I think someone went in and fixed the ARM reporting, I want to say it was @joaocgreis but I could well be misremembering.

[jbergstroem]

Have a faint memory @joaocgreis fixed it as well.

[Trott]

@Trott would you agree?

Honestly, I haven't been paying attention to it! Will try to do so over the next few hours/days.

[joaocgreis]

I fixed this. This issue looks like a duplicate of nodejs/build#572. I don't have permissions, but I think this can be closed now.

[jbergstroem]

Closing per @joaocgreis comment.