Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postinstall step #365

Closed
wants to merge 1 commit into from
Closed

Add postinstall step #365

wants to merge 1 commit into from

Conversation

tracker1
Copy link

AS the initial install won't actually run the postinstall, running the postinstall would probably be a good idea after copying the rest of the application. This would be much closer to the expected behavior.

AS teh initial install won't actually run the postinstall, running the postinstall would probably be a good idea after copying the rest of the application.  This would be much closer to the expected behavior.
@chorrell
Copy link
Contributor

We're more than likely going to deprecate the onbuild image at some point in the future.

See: docker-library/official-images#2076

ghost

This comment was marked as off-topic.

ghost

This comment was marked as off-topic.

ghost

This comment was marked as off-topic.

@tracker1
Copy link
Author

Kind of sad to see the move to push the -onbuild images out... They've been great, for me in terms of getting a project up/deployed quickly in, for example dokku. I mean, yeah, I can just put all the instructions that would be in -onbuild into the Dockerfile, beyond that, my build is usually a little more complex... that said, the onbuild images have been greatly appreciated.

@chorrell
Copy link
Contributor

Closing this out since onbuild variants are deprecated.

@chorrell chorrell closed this Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants