Update "gpg" usage to be more resilient to transient failure #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "gpg" is given multiple keys, it will only exit non-zero if _all_ the keys fail to download, so sometimes we'll get this line succeeding, but a transient failure (network, keyserver, or otherwise) can cause us to get a false positive and a build that fails later at verifying binaries.
|
LGTM |
chorrell
added a commit
that referenced
this pull request
Aug 6, 2015
Update "gpg" usage to be more resilient to transient failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "gpg" is given multiple keys, it will only exit non-zero if all the keys fail to download, so sometimes we'll get this line succeeding, but a transient failure (network, keyserver, or otherwise) can cause us to get a false positive and a build that fails later at verifying binaries.
See also docker-library/php#92 (and all the other PRs linked into that one).
(and the main reason I've made the PR is because the official build server actually ran into this scenario 😞 😇)