-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an alpine variant #156
Conversation
I think you shouldn't build node.js again,instead,you can downloads binary from offcial website.secondly, you should mark the package when you install them,for example:
so that you can remove it when it complete. |
@ChasonTang I tried that approach but the built binaries don't work on alpine |
0674d0e
to
e673d1d
Compare
For
|
There were plans to setup testing of Node.js on Alpine Linux and to eventually provide official binaries for Alpine Linux: I'm not sure where things are with that work though. |
49653ce
to
c659d89
Compare
b3ddb62
to
4561c97
Compare
I merged #162 |
This should also be dependent on #164 |
Does #164 solve the broken build issue? Also, it might be good to put this on hold for a bit. I'd like to know where things we at with the build group's plan to test on Alpine before we take this any further. |
@chorrell Not it doesn't but it simplifies this PR since it wont need to change the update script anymore |
An official website doesn't provide pre-built binaries for musl libc. |
@Vanuan oh,it's my fault,alpine node.js must build in the container. |
For some odd reason, the build only fails on node 0.10 for the alpine variants.... |
I don't think it's the image, it has something to do with accessing the gpg key server. I have another PR that's failing in the same place: https://travis-ci.org/nodejs/docker-node/builds/125849371 The PR just removes the |
|
For mine it's not the key, it fails the build around libuv... |
This is exactly what I get!! http://lists.busybox.net/pipermail/buildroot/2015-August/135182.html |
This is very unfortunate....the Travis Build doesn't have enough time to build all the alpine variants. Maybe it should be matrixed? |
So, can we build it for alpine one-time, put it somewhere, and then download it in the Dockerfile? |
As I can see, there's always the need to have 2 Dockerfiles: one for building, another for using it. I.e., prebuilt images should be placed to https://nodejs.org/dist/ |
I like that idea @Vanuan ! |
1e6fcb9
to
611588d
Compare
I did the v4.6.2 update |
2592371
to
790c313
Compare
Yes, 7.1 would replace 7.0 |
5722c3a
to
1d6ffe1
Compare
Attempt to get the build to work with alpine
1d6ffe1
to
d20d305
Compare
Ok, after a lot of rebasing, I updated to what it should be |
The build passed even if it's not showing up here again |
Yeah, the builds look good even though the status in the PR still shows it's pending: https://travis-ci.org/nodejs/docker-node/builds/174661216 I think we're good to merge this now :) |
I'll work on the PR for the docker hub |
Wooohooo! Thanks so much for working with me to get this in! |
@LaurentGoderre a decent icu is missing in this image. Ok you've compiled node exactly like the official way node binaries are distributed so that's great... but when you have to deal with intl/icu in some node apps (this is my case in many apps) this is pain in the ass to deal with full-icu package since a long time... and things don't get better with things like yarn for example as you can see yarnpkg/yarn#2124. So... I suggest to just add https://github.com/rezzza/docker-node/blob/master/6/Dockerfile#L24 and https://github.com/rezzza/docker-node/blob/master/6/Dockerfile#L48 in official alpine (and non alpine maybe, I don't use them) containers. Ok the generated container will be a little bigger but I guess it's a good tradeoff until some day full-icu will get fixed. On my side I can keep going building my own images - I've done that since at least 1 year - but I doubt to be the only guy in that situation and bringing a decent solution to everyone would be nice no? |
@shouze the lines referred don't seem to work for me? One point to a GPG key, the other to nowhere. In any case, could we discuss this in a new issue so that others may chime in? I don't like having discussions in closed PRs |
@LaurentGoderre ok sorry I didn't put the deeplink to the commit and pushed to that file since. |
The resulting container is around |
I'm not opposed to it but could you create an issue for this to get comments from others? |
@LaurentGoderre yes of course #286 feel free to tag it |
No description provided.