-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: Remove 386 architecture for v12 and v14 #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Support maybe be added back later #1344 (comment) |
Official support stopped in v8 and is currnetly all failing in the official-images CI. Can be re-enabled if support is fixed
Going to hold of landing this to test the new PR workflow with the 12.19.0 release PR (that hasn't been submitted yet) |
@ttshivers interesting, it doesn't look like it triggered the PR here. I wonder if it's related to the branch not being up-to-date at time of landing |
I am not seeing any runs of the action: https://github.com/nodejs/docker-node/actions?query=workflow%3A%22Create+official+images+PR%22. The triggers might not be working as expected? I am not sure yet why it wasn't triggered when this was closed. Looking into it. |
My first guess is maybe my suggeted filter for the merged was bad
|
I think if that was the issue, it would still show the actions, just they would be skipped. |
It appears the latest commit was not done with a merge commit, so that might be related? |
Right, the commit is showing before the PR commit, so maybe if you rebase the other one I can land it to see if it works then |
Done. That might be it. I tested this behavior with merge commits but will investigate further about what is happening: #1337 (comment) |
Official support stopped in v8 and is currnetly all failing in the
official-images CI.
Can be re-enabled if support is fixed