-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep dynamically linked files in slim images #1198
Conversation
I tested this on RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
&& apt-get update && apt-get install -y ca-certificates curl wget gnupg dirmngr --no-install-recommends \
# ...
&& apt-mark auto '.*' > /dev/null \
&& { [ -z "$savedAptMark" ] || apt-mark manual $savedAptMark > /dev/null; } \
&& apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false \
# smoke test
&& yarn --version |
can this be somehow resolved, since right now both $ docker run --rm node:13-slim --version
node: error while loading shared libraries: libatomic.so.1: cannot open shared object file: No such file or directory and $ docker run --rm node:12-slim --version
node: error while loading shared libraries: libatomic.so.1: cannot open shared object file: No such file or directory The last working one seems to be $ docker run --rm node:12.15-slim --version
v12.15.0 |
9ba4ff3
to
71849fa
Compare
I've rebased this now. @tianon thanks for testing! I added what I think is correct as a second commit now. Does that look right? Could you test again? |
cac3f7b
to
2caaf1a
Compare
Tested |
Wonderful, thanks for checking! @nodejs/docker PTAL 🙂 |
Looks like the Travis job failed on the deploy if someone can try and reset it https://travis-ci.com/nodejs/docker-node/jobs/288915013 |
Yeah, failed when gh had issues earlier. I was unable to open a manual pr as well. I'll restart it 🙂 |
Created PR to the official-images repo (docker-library/official-images#7493). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Should be merged after #1197. I kept them separate as I don't know how to test that this works for arm.
Fixes #1195