-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node.js v12 from v12.10.0 to v12.11.0 #1113
Conversation
PeterDaveHello
commented
Sep 26, 2019
- https://nodejs.org/en/blog/release/v12.11.0/
- https://github.com/nodejs/node/releases/tag/v12.11.0
- https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.11.0
Need some fixes. |
Interesting... I use nvm to build from source with
|
@nodejs/build is this a known issue? |
Thank you @nschonni |
Does it make sense to just pull out the alpine change and tag/release if for the other variants? |
if you feel like special-casing 12.11.0, you could do this: https://github.com/mhart/alpine-node/blob/12.11.0/Dockerfile#L35 (from nodejs/node#29709) to get it to compile. |
Thanks @trygve-lie, I noticed it, and its PR is on the way now. |
2e1bdf0
to
82f9946
Compare
@nodejs/docker can anyone help review this PR? Thanks. |
Should this just get skipped/replaced now that 12.11.1 is out? |
Not sure if anyone may still need this version for some reasons. |
we've had borked releases in the past that I'm sure haven't made it possible or practical to do docker images of, maybe skipping one is OK? |
That issue only affects Alpine images, the others are good, so I prefer to still have them, and it shouldn't have too much effort or overhead, right? |
This is good to go! |
Thanks @LaurentGoderre |
Created PR to the official-images repo (docker-library/official-images#6735) |
Oops, looks like the bot is alive again! |