Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js v12 from v12.10.0 to v12.11.0 #1113

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

@PeterDaveHello PeterDaveHello requested a review from a team September 26, 2019 04:39
@PeterDaveHello PeterDaveHello changed the title Update node.js v12 from v12.10.0 to v12.11.0 [WIP] Update node.js v12 from v12.10.0 to v12.11.0 Sep 26, 2019
@PeterDaveHello
Copy link
Member Author

Need some fixes.

@PeterDaveHello
Copy link
Member Author

Interesting... I use nvm to build from source with nvm install -s 12 and it failed the same way:

make[1]: *** No rule to make target '../deps/v8/test/torque/test-torque.tq', needed by 'd8d177c5960cc6d770ad1240b3eaf0b8c1e75e92.intermediate'.  Stop.
Makefile:101: recipe for target 'node' failed
make: *** [node] Error 2
nvm: install v12.11.0 failed!

@PeterDaveHello
Copy link
Member Author

@nodejs/build is this a known issue?

@nschonni
Copy link
Member

nodejs/node#29709

@PeterDaveHello
Copy link
Member Author

Thank you @nschonni

@nschonni
Copy link
Member

Does it make sense to just pull out the alpine change and tag/release if for the other variants?

@rvagg
Copy link
Member

rvagg commented Oct 1, 2019

if you feel like special-casing 12.11.0, you could do this: https://github.com/mhart/alpine-node/blob/12.11.0/Dockerfile#L35 (from nodejs/node#29709) to get it to compile.

@trygve-lie
Copy link

v12.11.1 is out: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2019-10-01-version-12111-current-targos

@PeterDaveHello
Copy link
Member Author

Thanks @trygve-lie, I noticed it, and its PR is on the way now.

@PeterDaveHello PeterDaveHello changed the title [WIP] Update node.js v12 from v12.10.0 to v12.11.0 Update node.js v12 from v12.10.0 to v12.11.0 Oct 1, 2019
@PeterDaveHello
Copy link
Member Author

@nodejs/docker can anyone help review this PR? Thanks.

@nschonni
Copy link
Member

nschonni commented Oct 2, 2019

Should this just get skipped/replaced now that 12.11.1 is out?

@PeterDaveHello
Copy link
Member Author

Not sure if anyone may still need this version for some reasons.

@rvagg
Copy link
Member

rvagg commented Oct 2, 2019

we've had borked releases in the past that I'm sure haven't made it possible or practical to do docker images of, maybe skipping one is OK?

@PeterDaveHello
Copy link
Member Author

That issue only affects Alpine images, the others are good, so I prefer to still have them, and it shouldn't have too much effort or overhead, right?

@LaurentGoderre
Copy link
Member

This is good to go!

@PeterDaveHello
Copy link
Member Author

Thanks @LaurentGoderre

@nodejs-github-bot
Copy link
Collaborator

Created PR to the official-images repo (docker-library/official-images#6735)

@PeterDaveHello
Copy link
Member Author

Oops, looks like the bot is alive again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants