Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS tag #52

Closed
retrohacker opened this issue Oct 13, 2015 · 13 comments
Closed

LTS tag #52

retrohacker opened this issue Oct 13, 2015 · 13 comments

Comments

@retrohacker
Copy link
Contributor

Would it be helpful to add an LTS tag in addition to the latest?

@Starefossen
Copy link
Member

I'm +1 for this.

@chorrell
Copy link
Contributor

How would this work? Would LTS just point to whatever the latest LTS release is?

@retrohacker
Copy link
Contributor Author

@chorrell my thought is that the LTS tag would point to the latest LTS release. For overlapping LTS releases, the LTS tag would point to the release with the highest major version.

@Starefossen
Copy link
Member

Another option may be to tag the different LTS versions with their code word. Similar to how the Debian Docker Image gets tagged :wheezy etc. The reason why I think this is a good idea is that people who want to be on an LTS version want to be on a specific LTS version until they are ready to jump to the next. Just tagging :lts will not be as beneficial as this will automatically become the next LTS version once a new one gets released. Also, there are some overlap between LTS versions.

@chorrell
Copy link
Contributor

I'm +1 on using the LTS code word. So:

docker pull node:argon

Would also get you the latest 4.2.* lts release. I like that because it's more controlled. I agree with @Starefossen someone who wants and LTS image more often than not care about a specific major/minor version.

@retrohacker
Copy link
Contributor Author

The code word is a pretty cool idea! I'm +1, and interested in what the @nodejs/lts team thinks of this.

So at any one time we could be maintaining at most 5 images? One LTS release (4.2.*), two stable releases (v5 and v6), and .12? If I'm looking at the right chart, that would be in April of 2016.

Then .10 and .12 sunset and we will be maintaining 3 images from then on: Two LTS releases, and one stable.

@jasnell
Copy link
Member

jasnell commented Oct 14, 2015

@wblankenship ... yep, you're correct. Up until the point where v0.10 and v.12 fall off, we'll have up to five releases being maintained. v0.10, v0.12 and v4.2.x are all LTS lines. v5.x will cut this week hopefully, and then master of course. v0.10 will fall off October 2016 and v0.12 will fall off December 2016. After that things become a bit more sane and regular.

@hmalphettes
Copy link
Member

I am +1 for argon and lts.
Here is how it looks like: hmalphettes@9f3ae6a

Let me know if I missed something.

hmalphettes added a commit to hmalphettes/official-images that referenced this issue Oct 30, 2015
@hmalphettes
Copy link
Member

Here is what the PR to docker's official images would look like:
hmalphettes/official-images@48e76fe

I granted all of you collaborators rights on my repo if that makes it easier to tweak something.

Let me know if we are happy with this and ready to turn this into a PR.

@hmalphettes
Copy link
Member

Sorry having re-read all this: i understand we agreed to not have the tag lts.
So only tagging v4 with argon then:
hmalphettes/official-images@5bfa1e5

hmalphettes added a commit to hmalphettes/official-images that referenced this issue Oct 30, 2015
@retrohacker
Copy link
Contributor Author

Looks good @hmalphettes! I think we can ship this.

@Starefossen
Copy link
Member

PR is up at docker-library/official-images#1151

@hmalphettes
Copy link
Member

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants