Skip to content
This repository has been archived by the owner on Jul 20, 2018. It is now read-only.

WG Required Documents #40

Merged
merged 5 commits into from
Apr 1, 2015
Merged

WG Required Documents #40

merged 5 commits into from
Apr 1, 2015

Conversation

retrohacker
Copy link
Contributor

Not to be merged prior to approval of nodejs/node#1134

Required for WG status
@pesho
Copy link
Contributor

pesho commented Mar 13, 2015

@wblankenship thanks for that.

Do we really need to have WG meetings on Hangouts? I think discussion on GitHub issues is enough.

@rvagg
Copy link
Member

rvagg commented Mar 13, 2015

you do it how works for you, Hangouts don't make a whole lot of sense where there's not a large bulk of work to do or if you're working well enough without face-to-face

@retrohacker
Copy link
Contributor Author

Agreed @pesho, lets remove that clause. Is it safe to say something along the lines of:

This wg does not have any meetings. All discussions and decisions will be documented via issues and pull requests in the repository.

@jlmitch5
Copy link

I'm cool with that

@Starefossen
Copy link
Member

I think keeping discussions/decisions on GitHub is reasonable for this working group.

And updated relevant sections.
@retrohacker
Copy link
Contributor Author

Updated document to say that we don't meet. Could use an extra set of eyes to make sure I didn't miss any sections, or that I didn't break any sections with the "no meeting" revisions.

modifications, or modifications that have not found consensus to the
WG for discussion by assigning the ***WG-agenda*** tag to a pull
request or issue. The WG should serve as the final arbiter where
required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thinking this will ever be an issue, but out of curiosity, how will this work in practice when there are no WG meetings? Will the issue be put on hold unit all WG-members have commented? In such a case, will that be contradictory to the consensus seeking process?

Update: I think my concerns are pretty much covered by the WG Meetings and Consensus Seeking Process sections.

@pesho
Copy link
Contributor

pesho commented Mar 15, 2015

The updated text looks good.

Here are a few extra suggestions, which seem within the scope of this PR:

  • Add the list of WG members to README.md along with a link to the GOVERNANCE document.
  • The current repo policy is to disallow direct changes to master, instead requiring all updates to be via pull requests. Assuming we want to keep this policy (+1 from me for keeping it), it should probably be documented.
  • Another current policy is to allow PRs with trivial changes (usually version bumps) to be merged immediately by a collaborator, without waiting for consensus, with a note explaining the reason for the merge. Maybe document this too.

@retrohacker retrohacker self-assigned this Mar 16, 2015
@jlmitch5
Copy link

Everything you did looks great :)

I'm also +1 on requiring PRs (and trivial ones being able to be directly pushed). I think feature branches should be off the user's fork as well (instead of being off of iojs/docker-iojs).

@retrohacker
Copy link
Contributor Author

Everything from @jlmitch5 @Starefossen and @pesho's recommendations have been integrated into the GOVERNANCE.md doc, and the README.md has been updated. Barring further tweaks, this is ready to be merged 😄

@jlmitch5
Copy link

Great job @wblankenship! +1 from me 👍 🎸 💎

@hmalphettes
Copy link
Member

Thanks @wblankenship.

@retrohacker
Copy link
Contributor Author

Need a 👍 to merge from:

@pesho
Copy link
Contributor

pesho commented Mar 30, 2015

+1 from me 😃

@Starefossen
Copy link
Member

Starefossen commented Mar 30, 2015 via email

1 similar comment
@hmalphettes
Copy link
Member

+1

retrohacker pushed a commit that referenced this pull request Apr 1, 2015
WG Required Documents

Merged by way of consensus
@retrohacker retrohacker merged commit 6355158 into master Apr 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants