Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg: nominating jkrems #87

Merged
merged 1 commit into from
Feb 23, 2017
Merged

wg: nominating jkrems #87

merged 1 commit into from
Feb 23, 2017

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Feb 16, 2017

Nominating @jkrems to the Diagnostics WG. Jan is the original author of node-inspect and as a member could better contribute to that project.

@jkrems this does depend on you wanting to be a member of the WG. The main requirement is that you check and contribute to issues here occasionally and try to attend meetings. Your work on node-inspect is already more than enough IMO.

We should discuss at the next meeting according to protocol. To be sure we have consensus, anyone from @nodejs/diagnostics who has objections should please chime in here. Thank you!

@joshgav joshgav merged commit 015bd30 into nodejs:master Feb 23, 2017
@joshgav
Copy link
Contributor Author

joshgav commented Feb 23, 2017

Discussed at meeting and no objections! Thanks for joining us @jkrems!

@jkrems
Copy link
Contributor

jkrems commented Feb 24, 2017

I think for CI purposes it would be important to be added to some Github team as well (unless that already happened..?), as per:

And specifically, he does not need to be a collaborator, just a member of the team configured for the diagnostics workgroup.

@joshgav
Copy link
Contributor Author

joshgav commented Feb 24, 2017

@jkrems

it would be important to be added to some Github team as well

Indeed, now we need someone to add you to the @nodejs/diagnostics team. I'm not an admin there; @Fishrock123 @mhdawson @ofrobots can one of you add @jkrems to that team, and perhaps make me an admin at the same time so I can do that in the future? Thank you!

@mhdawson
Copy link
Member

I've triggered the invite to jkrems to have him added to the team.

@mhdawson
Copy link
Member

@joshgav I promoted you to a team maintainer as I think that makes sense given your involvement.

@jkrems
Copy link
Contributor

jkrems commented Feb 24, 2017

Worked, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants