Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Diagnostics WorkGroup Meeting 2022-02-08 #526

Closed
mhdawson opened this issue Feb 7, 2022 · 12 comments
Closed

Node.js Diagnostics WorkGroup Meeting 2022-02-08 #526

mhdawson opened this issue Feb 7, 2022 · 12 comments
Assignees
Labels

Comments

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2022

Time

UTC Tue 08-Feb-2022 16:00 (04:00 PM):

Timezone Date/Time
US / Pacific Tue 08-Feb-2022 08:00 (08:00 AM)
US / Mountain Tue 08-Feb-2022 09:00 (09:00 AM)
US / Central Tue 08-Feb-2022 10:00 (10:00 AM)
US / Eastern Tue 08-Feb-2022 11:00 (11:00 AM)
EU / Western Tue 08-Feb-2022 16:00 (04:00 PM)
EU / Central Tue 08-Feb-2022 17:00 (05:00 PM)
EU / Eastern Tue 08-Feb-2022 18:00 (06:00 PM)
Moscow Tue 08-Feb-2022 19:00 (07:00 PM)
Chennai Tue 08-Feb-2022 21:30 (09:30 PM)
Hangzhou Wed 09-Feb-2022 00:00 (12:00 AM)
Tokyo Wed 09-Feb-2022 01:00 (01:00 AM)
Sydney Wed 09-Feb-2022 03:00 (03:00 AM)

Or in your local time:

Links

Agenda

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/diagnostics

  • meeting time, again #507
  • Identify async_hooks use cases beyond AsyncLocalStorage #437

Invited

  • Diagnostics team: @nodejs/diagnostics

Observers/Guests

Notes

The agenda comes from issues labelled with diag-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Feb 7, 2022
@gireeshpunathil
Copy link
Member

I have a time conflict with this instance that I cannot resolve. @mhdawson - are you in a position to chair this one?

@mhdawson
Copy link
Member Author

mhdawson commented Feb 7, 2022

I can chair this one.

@RafaelGSS
Copy link
Member

The meeting has started? It looks like nobody started it yet.

@Qard
Copy link
Member

Qard commented Feb 8, 2022

Yeah, still just waiting here.

@RafaelGSS
Copy link
Member

I'll try to re-enter

@tony-go
Copy link
Member

tony-go commented Feb 8, 2022

I'm here too ^^

@bmeck
Copy link
Member

bmeck commented Feb 8, 2022

I'll pop on as host

@tony-go
Copy link
Member

tony-go commented Feb 8, 2022

Hi 👋🏼

If I have technical questions regarding topics we tackle today. Should I post them here ?

@bmeck
Copy link
Member

bmeck commented Feb 8, 2022 via email

@mhdawson
Copy link
Member Author

mhdawson commented Feb 9, 2022

Sorry I missed this, I have a family emergency and will be out for a few days.

@tony-go
Copy link
Member

tony-go commented Feb 9, 2022

Sure, then we can triage if they need their own issue

Thanks @bmeck 🙌 ^^ It's more to be sure to understand the big issue there:

  • My first question was related to diagnostics_channels. Yesterday you mention that it should be brought "to the core". Does that mean that it should be moved from lib to src? (And more generally, is "core" mean src/cpp ?)
  • Regarding the high cost of using AsyncLocalStorage you mention, the solution should be the same as diagnostics_channels?
  • What is the cause of the memory issues you mentioned regarding the usage of async_hooks?

If anyone starts something, I'll happy to look at the PR :)

Sorry I missed this, I have a family emergency and will be out for a few days.

@mhdawson 💪

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants