-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add limited support for devEngines
and .corepack.env
#634
base: main
Are you sure you want to change the base?
Conversation
devEngines
devEngines
and .corepack.env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we separate into two PRs since this sounds like two separate features?
- add support for
devEngines
- add support for
.corepack.env
This way we don't block the devEngines feature on account of any bikesheding that could come from .corepack.env
Can you please explain these limitations? |
This PR introduces the concept of
.corepack.env
which would allow project maintainers to customize some parts of Corepack.We realistically cannot release it until Node.js 18.x is EOL(env parser is only available on Node.js 20.x LTS and later) in April, EDIT: actually it won't be as big of a deal as I thought, it falls back elegantly when run on a Node.js version without.env
support.devEngines
support in this PR is limited topackageManager
only, only onepackageManager
can be specified, theonFail
field is ignored.This PR also does not add support ofEDIT: this has been addresseddevEngines
tocorepack use
andcorepack up
, which should be addressed before releasing.Fixes: #567
Fixes: #402
Fixes: #95
Should unblock fixing: #628