Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows malicious file analysis waiting problem #398

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Fix Windows malicious file analysis waiting problem #398

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67d4130
Fixed Windows malicious file analysis waiting problem
ngnlTeto Feb 26, 2024
26e3cfe
ajusted used error codes
ngnlTeto Feb 26, 2024
455ed87
Update sources/corepackUtils.ts
ngnlTeto Feb 26, 2024
88d6155
exported the logic to rename a folder in Windows to a separate function
ngnlTeto Feb 26, 2024
a0a1e42
changed setTimeout to setTimeout from node:timers/promises
ngnlTeto Feb 26, 2024
9165558
corrected comment about Windows malicious file analysis
ngnlTeto Feb 26, 2024
37f7c6d
added exponential increasing timeouts for slower machines
ngnlTeto Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion sources/corepackUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type {Dir} from 'fs';
import Module from 'module';
import path from 'path';
import semver from 'semver';
import {setTimeout as setTimeoutPromise} from 'timers/promises';

import * as engine from './Engine';
import * as debugUtils from './debugUtils';
Expand Down Expand Up @@ -213,7 +214,11 @@ export async function installVersion(installTarget: string, locator: Locator, {s

await fs.promises.mkdir(path.dirname(installFolder), {recursive: true});
try {
await fs.promises.rename(tmpFolder, installFolder);
if (process.platform === `win32`) {
await renameUnderWindows(tmpFolder, installFolder);
} else {
await fs.promises.rename(tmpFolder, installFolder);
}
} catch (err) {
if (
(err as nodeUtils.NodeError).code === `ENOTEMPTY` ||
Expand Down Expand Up @@ -260,6 +265,30 @@ export async function installVersion(installTarget: string, locator: Locator, {s
};
}

async function renameUnderWindows(oldPath: fs.PathLike, newPath: fs.PathLike) {
// Windows malicious file analysis blocks files currently under analysis, so we need to wait for file release
const retries = 5;
for (let i = 0; i < retries; i++) {
try {
await fs.promises.rename(oldPath, newPath);
break;
} catch (err) {
if (
(
(err as nodeUtils.NodeError).code === `ENOENT` ||
(err as nodeUtils.NodeError).code === `EPERM`
) &&
i < (retries - 1)
) {
await setTimeoutPromise(100 * 2 ** i);
continue;
} else {
throw err;
}
}
}
}

/**
* Loads the binary, taking control of the current process.
*/
Expand Down