-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download yarn from custom npm registry #396
Download yarn from custom npm registry #396
Conversation
I don't know how reasonable it is to ask, but it'd be nice to have a test that emulates a custom registry so we can validate we don't introduce regressions with future changes. |
Okay, I'll add a test case later today. |
2bffa55
to
7423405
Compare
It looks like tests are failing, you probably need to update the nock db – you’d need to run the tests with |
…e/corepack into feat/download-from-custom-registry
#339 uses custom npm registry to resolve package manager versions. However, it still downloads from npm since
spec.url
is set torepo.yarnpkg.com
.This PR trys to resolve a tarball from npm registry when
COREPACK_NPM_REGISTRY
is set. Moreover, as configuredspec.bin
for yarn berry only support package manager downloaded as.js
file, thebin
config for custom package managers is used and now has higher priority thanspec.bin
.This should completely fix #337