Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Yarn #308

Merged
merged 1 commit into from
Sep 11, 2023
Merged

chore: update Yarn #308

merged 1 commit into from
Sep 11, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Sep 11, 2023

Node.js v20.6 changed the ESM loader a bit so the version of Yarn used by Corepack needs to be updated to a version containing yarnpkg/berry#5677.

Fixes the install failing on Node.js v20.

Ref #307 (comment)

@merceyz
Copy link
Member Author

merceyz commented Sep 11, 2023

The release candidate of Yarn v4 that contains the fix has dropped support for Node.js v16 so we'll either need to do the same, downgrade to Yarn v3, or backport the fix to a v4 release candidate that still supported v16.

Copy link
Contributor

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js v16 is officially EOL starting from today(!), so we probably can remove it from the CI

@arcanis arcanis requested a review from aduh95 September 11, 2023 20:19
@aduh95 aduh95 merged commit c085753 into nodejs:main Sep 11, 2023
7 of 10 checks passed
@merceyz merceyz deleted the merceyz/deps/yarn branch September 11, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants