chore: add engines.node to package.json
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
commented
Jan 4, 2023
| "module": "commonjs", | ||
| "resolveJsonModule": true, | ||
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "target": "es2017" | ||
| "target": "ES2020" |
There was a problem hiding this comment.
According to https://node.green/#ES2020 Node.js v14.14.0 doesn't fully support ES2020 but we're not using spread parameters after optional chaining so that's fine, if we ever do use it the CI will catch it assuming v14 doesn't update to a version of v8 that supports it.
In a future PR I'll ensure spread parameters after optional chaining is transpiled.
arcanis
approved these changes
Jan 4, 2023
styfle
reviewed
Jan 6, 2023
| @@ -22,7 +22,7 @@ module.exports = { | |||
| loader: `ts-loader`, | |||
| options: { | |||
| compilerOptions: { | |||
| module: `es2020`, | |||
| module: `ES2020`, | |||
There was a problem hiding this comment.
I wonder if this should read from tsconfig.json here to keep them in sync?
There was a problem hiding this comment.
That's a good idea however my next PR will replace webpack with esbuild so they shouldn't have time to go out of sync.
aduh95
approved these changes
Jan 7, 2023
sounisi5011
added a commit
to sounisi5011/package-version-git-tag
that referenced
this pull request
Mar 24, 2023
Corepack is available for all currently supported Node.js. see nodejs/corepack#227 Therefore, we stop installing each package manager manually and enable Corepack in all Node.js environments.
sounisi5011
added a commit
to sounisi5011/package-version-git-tag
that referenced
this pull request
Mar 24, 2023
* 💚 Using Corepack with all Node.js Corepack is available for all currently supported Node.js. see nodejs/corepack#227 Therefore, we stop installing each package manager manually and enable Corepack in all Node.js environments. * 📝 Update CHANGELOG
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
v0.11.0 (specifically #100) dropped support for Node.js v12 and raised the bar to Node.js v14.14.0 due to
corepack/sources/fsUtils.ts
Line 4 in 82a6715
Addresses #100 (review)
How did you fix it?
Added
engines.nodetopackage.jsonto document the minimum version.