-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies, remove unused ones #100
Merged
+19,125
−23,939
Merged
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
174f8e2
chore: update dependencies, remove unused ones
aduh95 1f064e9
fix types
aduh95 cc7d5cb
Updates snapshots
arcanis 14a9df0
Fixes prepack
arcanis 4a275f6
try with Node.js 16.x
aduh95 448747e
Update more packages
aduh95 e02154b
Upgrade to Jest 28
aduh95 e251475
Bump other packages
aduh95 29ecdfc
Bump other packages
aduh95 45aa8a3
Use Node.js 14.19.2
aduh95 8e97cb5
Revert "try with Node.js 16.x"
aduh95 dc03ab9
Use specific Node.js version
aduh95 edcf040
trying something
aduh95 dd72a68
Pin exact Node.js version number
aduh95 6de78ef
Bump Jest to 28.1.0
aduh95 15ed8c4
dist-upgrade
aduh95 c5e13d1
Don't pin Node.js version when it's not necessary
aduh95 7b9a656
Update more dependencies
aduh95 1c6473f
Update more dependencies
aduh95 fa284c0
Revert "Pin exact Node.js version number"
aduh95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,38 +8,38 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| platform: | ||
| - [linux, ubuntu-latest] | ||
| - [darwin, macos-latest] | ||
| - [linux, ubuntu-latest] | ||
| - [darwin, macos-latest] | ||
|
|
||
| runs-on: ${{matrix.platform[1]}} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 14.x | ||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 14.x | ||
|
|
||
| - name: 'Build Node with corepack master' | ||
| run: | | ||
| yarn install --immutable | ||
| yarn pack | ||
| git clone -b mael/pmm --depth=1 https://github.com/arcanis/node.git node && cd node | ||
| git config user.name 'John Doe' | ||
| git config user.email '[email protected]' | ||
| rm -rf deps/corepack && tar xvf ../package.tgz && mv package deps/corepack | ||
| git add . | ||
| if ! git diff-index --quiet HEAD; then | ||
| git commit -m 'Updates corepack' | ||
| git show --name-status | ||
| fi | ||
| ./configure | ||
| DISTTYPE=nightly DATESTRING=YYYY-MM-DD COMMIT=XXXX make binary -j8 | ||
| mv node-v15.0.0-nightlyYYYY-MM-DDXXXX-*.tar.gz node-corepack-${{matrix.platform[0]}}-x64.tar.gz | ||
| - name: "Build Node with corepack master" | ||
| run: | | ||
| corepack yarn install --immutable | ||
| corepack yarn pack | ||
| git clone -b mael/pmm --depth=1 https://github.com/arcanis/node.git node && cd node | ||
| git config user.name 'John Doe' | ||
| git config user.email '[email protected]' | ||
| rm -rf deps/corepack && tar xvf ../package.tgz && mv package deps/corepack | ||
| git add . | ||
| if ! git diff-index --quiet HEAD; then | ||
| git commit -m 'Updates corepack' | ||
| git show --name-status | ||
| fi | ||
| ./configure | ||
| DISTTYPE=nightly DATESTRING=YYYY-MM-DD COMMIT=XXXX make binary -j8 | ||
| mv node-v15.0.0-nightlyYYYY-MM-DDXXXX-*.tar.gz node-corepack-${{matrix.platform[0]}}-x64.tar.gz | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: node-corepack-${{matrix.platform[0]}}-x64 | ||
| path: node/node-corepack-${{matrix.platform[0]}}-x64.tar.gz | ||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: node-corepack-${{matrix.platform[0]}}-x64 | ||
| path: node/node-corepack-${{matrix.platform[0]}}-x64.tar.gz | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,52 +3,52 @@ name: Version Sync | |
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 0 * * *' | ||
| - cron: "0 0 * * *" | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 14.x | ||
|
|
||
| - name: 'Update the package manager versions' | ||
| run: | | ||
| LATEST_NPM=$(curl https://registry.npmjs.org/npm | jq '.["dist-tags"].latest') | ||
| LATEST_PNPM=$(curl https://registry.npmjs.org/pnpm | jq '.["dist-tags"].latest') | ||
| LATEST_YARN=$(curl https://registry.npmjs.org/yarn | jq '.["dist-tags"].latest') | ||
| LATEST_BERRY=$(curl https://repo.yarnpkg.com/tags | jq '.latest.stable') | ||
|
|
||
| jq < config.json > config.json.new '. * '"{ | ||
| definitions: { | ||
| npm: { | ||
| default: $LATEST_NPM, | ||
| }, | ||
| pnpm: { | ||
| default: $LATEST_PNPM, | ||
| }, | ||
| yarn: { | ||
| default: $LATEST_YARN, | ||
| transparent: { | ||
| default: $LATEST_BERRY, | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 14.x | ||
|
|
||
| - name: "Update the package manager versions" | ||
| run: | | ||
| LATEST_NPM=$(curl https://registry.npmjs.org/npm | jq '.["dist-tags"].latest') | ||
| LATEST_PNPM=$(curl https://registry.npmjs.org/pnpm | jq '.["dist-tags"].latest') | ||
| LATEST_YARN=$(curl https://registry.npmjs.org/yarn | jq '.["dist-tags"].latest') | ||
| LATEST_BERRY=$(curl https://repo.yarnpkg.com/tags | jq '.latest.stable') | ||
|
|
||
| jq < config.json > config.json.new '. * '"{ | ||
| definitions: { | ||
| npm: { | ||
| default: $LATEST_NPM, | ||
| }, | ||
| pnpm: { | ||
| default: $LATEST_PNPM, | ||
| }, | ||
| yarn: { | ||
| default: $LATEST_YARN, | ||
| transparent: { | ||
| default: $LATEST_BERRY, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }" | ||
| }" | ||
|
|
||
| rm config.json | ||
| mv config.json.new config.json | ||
| rm config.json | ||
| mv config.json.new config.json | ||
|
|
||
| if [[ ! -z "$(git status --porcelain)" ]]; then | ||
| git config user.email '[email protected]' | ||
| git config user.name 'Node.js GitHub Bot' | ||
| if [[ ! -z "$(git status --porcelain)" ]]; then | ||
| git config user.email '[email protected]' | ||
| git config user.name 'Node.js GitHub Bot' | ||
|
|
||
| git add config.json | ||
| git commit -m 'chore: update package manager versions' | ||
| git push | ||
| fi | ||
| git add config.json | ||
| git commit -m 'chore: update package manager versions' | ||
| git push | ||
| fi | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you call
corepack yarnrather than justyarn(same in the other places)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it explicit that we want to use the Corepack version of Yarn, in case Yarn v1.x is installed on the runner. Also, if someone is using this file to know what command to use to run the tests, it's the most likely command to succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, perhaps calling
corepack enable(or perhapssudo corepack enable) beforehand would be better - from a CLI user experience point of view, I'd prefer if Corepack didn't require any change, to guarantee reduced friction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that might be desirable for CLI usage, I'm doubtful it's a valid point in a CI context. The tests already ensures that calling the
corepackbinary is optional oncecorepack enablehas been run, right?Adding a
corepack enablestep in CI seems "wasteful" to me, but if you feel strongly about this, that's fine by me. wdyt?