Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows malicious file analysis waiting problem #398

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Fix Windows malicious file analysis waiting problem #398

merged 7 commits into from
Feb 27, 2024

Conversation

ngnlTeto
Copy link
Contributor

Fixes #246

That should fix the problem that windows malicious file analysis blocks the freshly downloaded file.
I couldn't reproduce the error on my side currently, but it should help.

@ngnlTeto
Copy link
Contributor Author

I was able to reproduce it and verify that it fixed the error.

sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
sources/corepackUtils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Windows machine to confirm if it solves the issue, but the code LGTM

@aduh95 aduh95 enabled auto-merge (squash) February 27, 2024 09:07
@aduh95 aduh95 merged commit 295a1cd into nodejs:main Feb 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

corepack preapre : ENOENT: no such file or directory, stat
4 participants