Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add wasm subsystem #82

Merged
merged 2 commits into from
Nov 5, 2019
Merged

lib: add wasm subsystem #82

merged 2 commits into from
Nov 5, 2019

Conversation

guybedford
Copy link
Contributor

It would be useful to have a generic Web Assembly dedicated subsystem at this point, which also will allow us to handle WASI as well until we have its builtin name set.

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files          18       18           
  Lines         448      448           
=======================================
  Hits          273      273           
  Misses        175      175
Impacted Files Coverage Δ
lib/rules/subsystem.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311ccb5...676f563. Read the comment docs.

@richardlau
Copy link
Member

There's some support for adding wasi instead (or maybe we could add both if that makes sense?): nodejs/node#30258 (comment)

@guybedford
Copy link
Contributor Author

@richardlau sure, I've added a wasi one as well. Then, if the subsystem changes in the process of merging that PR we can update this too.

@richardlau richardlau merged commit ffaaf43 into nodejs:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants