feat: add TypeScript types #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SimenB
commented
Nov 1, 2020
| reexports: string[]; | ||
| } | ||
|
|
||
| export declare function parse(source: string, name?: string): Exports; |
There was a problem hiding this comment.
not sure if name should be here? afaict it's not documented
guybedford
reviewed
Nov 1, 2020
| export declare function parse(source: string, name?: string): Exports; | ||
| export declare function init(): Promise<void>; | ||
|
|
||
| export {}; |
There was a problem hiding this comment.
Out of interest, what is this line for?
There was a problem hiding this comment.
Not 100% sure 😅 I didn't write these definitions manually, I used the TS playground to "implement" this module and copied out the generated d.ts file.
Pick .D.TS in the right column. The one with the interface (which I went for) has the empty export {} at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.
Types depends on #27 to be correct for non-ESM users