Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not emit Object.defineProperty exports #24

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Do not emit Object.defineProperty exports #24

merged 1 commit into from
Oct 29, 2020

Conversation

guybedford
Copy link
Collaborator

This disables the emission of arbotrary Object.defineProperty exports, to fix the issue posted in nodejs/node#35859.

__esModule detection is handled as an exception only.

bmeck
bmeck reviewed Oct 29, 2020
View reviewed changes
test/_unit.js Show resolved Hide resolved
@guybedford guybedford merged commit 89cde88 into master Oct 29, 2020
@guybedford guybedford deleted the remove-define branch October 29, 2020 17:13
@targos targos mentioned this pull request Oct 31, 2020
Closed
@guybedford guybedford mentioned this pull request Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeck bmeck bmeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guybedford @bmeck