Only include last reexport assignment #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the reexport detection to only handle the last reexport assignment.
For example:
before this PR would return
a
,b
, and after this PR would return justb
.The rationale here is that Webpack bundles include
module.exports = require('external')
for every single external they import from, when those aren't actually reexports. This saves unnecessary work and overclassification in those cases, with what doesn't seem to be too much of a loss.